Avoid creating functions at jump table entries in shared cache#8002
Open
Avoid creating functions at jump table entries in shared cache#8002
Conversation
bdash
reviewed
Mar 23, 2026
| } | ||
| } | ||
|
|
||
| static bool HeuristicIsAFunction(Platform* targetPlatform, std::shared_ptr<VirtualMemory> vm, uint64_t func) |
Contributor
There was a problem hiding this comment.
It's probably best to use the same logic as MachoView::IsValidFunctionStart so we get consistent behavior. Ideally we'd share that code, but for whatever reason none of the Mach-O handling is shared at present.
Member
Author
There was a problem hiding this comment.
yeah that a good point I kind forgot that existed
Extract MachoView::IsValidFunctionStart logic into a shared inline function and reuse it in the shared cache MachOProcessor to skip creating functions at jump table entries (udf/trap instructions).
plafosse
force-pushed
the
fix/shared-cache-jump-table-functions
branch
from
3cc4a96 to
7ad9550
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
sub_functions.HeuristicIsAFunctioncheck before callingAddFunctionForAnalysis. On aarch64, if the first instruction at the candidate address disassembles asudf, the entry is skipped —udfis used as padding/data in jump tables and is never a valid function prologue.Fix #7992